Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SINPE Movil #163

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

Add support for SINPE Movil #163

wants to merge 46 commits into from

Conversation

onmax
Copy link
Member

@onmax onmax commented May 30, 2024

What to Review?

  • Review the new sidebar logic as the current implementation might not be correct
  • Add link to ‘Learn more’ in SinpeModalSellInfoModal.vue
  • New useSinpeMovil composable with all the logic
  • New AssetTransfer will all the templating and some logic for swaps that include FIAT. In the future, if we need to implement a swap, we would just need to create a new composable very similar to useSinpeMovil
  • New Sinpe Mobile Verification
  • We need a more generic way to work with the OASIS api lib to allow multiple endpoints. Currently we are setting sinpe movil app-wide but we need to also support Oasis EUR. See this line. @sisou is working on a solution
  • New RouteName enum for routes app-wide to avoid using raw strings. This is not a breaking change. It is more like adding TS to the routes so we have better DX

TODO

  • Merge PR in libswap, oasis-js and fastopot-api. Then update dependencies accordingly in package.json
  • Merge PR in keyguard and hub
  • Remove hardcoded phone number for testgin

Related PR

Changelog

  • Create new RouteName enum.
  • New Sidebar logic to enable/disable "Sell"
  • Created new Sell Modal Sinpe Info and Sinpe Mobile Verification Modal.
  • Created AssetTransfer: A component that will consume a composable that have all the required data for the swap. So UI and logic are divided.
  • New components: DualCurrencyInput (will be also ported to Nimiq Pay soon, that's why I took some time to do this now)
  • Updated in the whole app the TS code to handle the case of SwapAsset.CRC and SwapAsset.LBTC, which has been added to the oasis lib
  • Created new store for sinpe. We need to keep the phone number, name, tokens created in the phone verification flow and use it in the swap modal
  • The swap stores the sms settlement token
    -Hub and keyguard updated. Keyguard also includes new designs for Sinpe Movil.
  • libswap, oasis-js and fastopot-api updated. See related PR

@onmax onmax force-pushed the onmax/sinpe branch 6 times, most recently from 370d9a6 to b587054 Compare June 17, 2024 09:34
@onmax onmax requested a review from sisou August 13, 2024 14:40
@onmax onmax marked this pull request as ready for review August 13, 2024 14:43
@sisou sisou force-pushed the onmax/sinpe branch 2 times, most recently from f10ad4a to 9269125 Compare August 13, 2024 15:58
@onmax onmax changed the title [WIP] Add support for SINPE Movil Add support for SINPE Movil Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants